Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Stylelint v16 #540

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Mar 22, 2024

Which issue, if any, is this issue related to?

Closes #511

Is there anything in the PR that needs further explanation?

See https://stylelint.io/CHANGELOG#1600

Note that this PR bumps stylelint and stylelint-scss in dev deps.

@ybiquitous ybiquitous added the pr: dependencies relates to dependencies label Mar 22, 2024
@ybiquitous ybiquitous changed the title ci: test Stylelint v16 feat: support Stylelint v16 Mar 22, 2024
@ybiquitous
Copy link
Member Author

It seems that a segmentation fault error happens, related to:
https://stylelint.io/migration-guide/to-16/#jest-preset-stylelint

@ybiquitous
Copy link
Member Author

It may be timing to switch from Jest to Vitest... 🤔

@ota-meshi
Copy link
Member

I didn't know that Jest had such a problem:sweat: I think it's good to switch to Vitest if possible.

@ybiquitous
Copy link
Member Author

@ota-meshi Have you some experience of Vitest? I don't know it so much, honestly 😅

@ota-meshi
Copy link
Member

Sorry, I'm not familiar with Vitest 😅

@kizu
Copy link
Member

kizu commented May 2, 2024

Hey hey! Just want to mention that it would be really nice to make the vs code extension work with the v16 of stylelint, so we could upgrade its version in our codebase! Is there any rough ETA for when this PR could be finished?

@ybiquitous
Copy link
Member Author

@kizu I have no time to tackle this PR, including dependency problems, for now. 😓

If you are interested, you could tackle this challenge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: dependencies relates to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants