default variant #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetkuslular
commented
Dec 8, 2019
ahmetkuslular
commented
- If the variant sent does not match, the default variant usage is added
gbhasha
suggested changes
Oct 12, 2021
| @@ -30,7 +30,11 @@ function theme(name, values) { | |||
| theme.variants = function(name, prop, values) { | |||
| return function(props) { | |||
| var variant = props[prop] && values[props[prop]]; | |||
| return variant && getThemeValue(name, props, variant); | |||
| var defaultVariant = props[prop] && values['default']; | |||
There was a problem hiding this comment.
This assumes that there is 'default' key in the variants object. In few use cases we may not be having 'default' as one of the item in the list of variants. In such case, I suggest to use the first item from the list of variants as a fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.