A11y fixes and other minor issues #924
Conversation
| @@ -32,7 +32,7 @@ const ParentComponent = styled.div` | |||
| color: royalblue; | |||
|
|
|||
| ${TargetedComponent} { | |||
| color: tomato; | |||
There was a problem hiding this comment.
For this one we were using html color names just for legibility, maybe you could find an alternate named color? https://en.wikipedia.org/wiki/Web_colors
There was a problem hiding this comment.
@probablyup, none of the orange colors do not pass the contrast ratio, how about using any of these colors (and adjusting the examples accordingly)?
Or, I can revert the color changes and merge only the other fixes?
There was a problem hiding this comment.
I haved reviewed every change in 9 files.
File 1: key={title} added a key to section
File 2: role="presentation" add role to img
File 3: role="presentation" add role to img
File 4: removed color tomato
File 5: background: #E42200; changed background
File 6: background: #E42200; changed background
File 7: color: #E42200;
border-color: #E42200; added color to button tomato
File 8: Added keys : give a unique identity to every element
File 9: Added keys : give a unique identity to every element
This PR is another partial fix for #904, it contains:
role=presentationfor the showcase images that were missing alt attributekeyattr