Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

Add attributes mapped, is_association and data_source #838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philippemilink
Copy link
Contributor

Hi,
I added some attributes to column, and changed a little bit the way of generating the data response: there is now two rows arrays: the first one contains the data from the database and the second one contains the result displayed in the table.
This is useful to reuse the data in another column, to make eventually another transformation on the data. Moreover, we can now use the attribute mapped set to False to create columns based on data from other column.

Requires PRs #816, #837.

* allow to create column not mapped, and not defined with DQL
* allow to use data from another column and transform it
* add documentation
@stephanvierkant
Copy link
Collaborator

stephanvierkant commented Aug 26, 2019

This PR should be merged to fix the broken feature: #839

@philippemilink Can you resolve conflicts* and add the LinkColumn to \Sg\DatatablesBundle\Tests\Datatables\PostDatatable so we know it's working?

Because \Sg\DatatablesBundle\Datatable\Column\ColumnInterface has been changed, we would require a version bump.

*Copy .php_cs.dist and run php-cs-fixer fix before merging, that makes it a lot easier.

@philippemilink
Copy link
Contributor Author

Since @stephanvierkant made his own PR (#914), can I close this one ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants