Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

Locale aware for datefilter #640

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Locale aware for datefilter #640

wants to merge 4 commits into from

Conversation

nicodmf
Copy link
Contributor

@nicodmf nicodmf commented Jun 28, 2017

No description provided.

@nicodmf
Copy link
Contributor Author

nicodmf commented Aug 9, 2017

@stwe ping :)

@nicodmf
Copy link
Contributor Author

nicodmf commented Sep 19, 2017

ping @stwe

@nicodmf
Copy link
Contributor Author

nicodmf commented Mar 5, 2018

@Seb33300 ping

@Seb33300
Copy link
Collaborator

Seb33300 commented Mar 6, 2018

I think the filter should depend on the related column date format, not on the locale.

@nicodmf
Copy link
Contributor Author

nicodmf commented Mar 19, 2018

Yes you're right, but this locale choice doesn't break that, it's just take the date from the locale format used by client, or whatever the developper configure. If the client format in french, the developper can take the actual local and take the date in french, if the client format in english, it take the format in english.

Actually, the datefilter range cannot tale a french date by exemple.

@nicodmf
Copy link
Contributor Author

nicodmf commented Jun 3, 2018

@Seb33300 ping we have many improvement in this essential bundle, can you see and work it ?

Co-Authored-By: Stephan Vierkant <stephan@vierkant.net>
@nicodmf
Copy link
Contributor Author

nicodmf commented Jun 12, 2019

@stephanvierkant thanks for reviewing, a fix made in january is just a non sense and we should surelly commit a better locale intégration

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants