Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribers #99

Open
NicholasLYang opened this issue Feb 27, 2018 · 7 comments
Open

Subscribers #99

NicholasLYang opened this issue Feb 27, 2018 · 7 comments
Assignees

Comments

@NicholasLYang
Copy link
Contributor

Um, yeah. Subscriptions don't actually do anything right now...We should probably change that. Also, instead of a subscribe button, we should turn that into a sign up button since subscriptions don't work.

screen shot 2018-02-26 at 7 34 21 pm

@NicholasLYang NicholasLYang self-assigned this Feb 27, 2018
@jsonkao
Copy link
Member

jsonkao commented Feb 27, 2018

Subscriptions do create Subscribers. It's just that we have no newsletter to share.

@NicholasLYang
Copy link
Contributor Author

Yeah that’s what I mean by “don’t do anything”. Maybe until newsletters are a thing we should hide the functionality

@jsonkao
Copy link
Member

jsonkao commented Feb 27, 2018

The button is just nice for UI in my opinion. I fully acknowledge your point, but it's not cluttering the site; it's making the site less bare and more colorful.

@AndySok
Copy link
Contributor

AndySok commented Apr 15, 2021

For devs: if you want to take this project, ask us to connect you with the EiCs so you understand what the subscribers are currently used for

@jsonkao
Copy link
Member

jsonkao commented Apr 17, 2021

Grandpa is proud

selfie-0
GitHub Selfies

@AndySok
Copy link
Contributor

AndySok commented Apr 17, 2021

oh we're just getting started >:)

@jsonkao
Copy link
Member

jsonkao commented Apr 17, 2021

Grandpa is still proud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants