Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds chips to push roles #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds chips to push roles #45

wants to merge 2 commits into from

Conversation

AndySok
Copy link
Contributor

@AndySok AndySok commented Jun 29, 2020

Add the feature suggested in #35, which replaces the select field with chips from RWMC. By selecting multiple chips the editor can add multiple roles to the new user! Icons included.

@AndySok AndySok mentioned this pull request Jun 29, 2020
Open
vs2961
vs2961 requested changes Jun 30, 2020
View reviewed changes
Copy link
Member

@vs2961 vs2961 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be a little bit confusing when people are editing users, because the roles already on the user are not shown. It would be a nice feature for the person using the gui to see what roles are already selected.

Screenshot from 2020-06-30 11-16-10
vs.
Screenshot from 2020-06-30 11-16-16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vs2961 vs2961 vs2961 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndySok @vs2961