Add tests/docs to core OPDS module #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 🎉 Start stateful job rewrite scuffed * 🚧 Restore job state Lots of foundational work * woof * Fix incorrect schema items * Update serde and tokio * Add worker count config variable * Add dunder directory for personal progress * More progress * Further JobManager progress * Additional structuing on new manager. * Additional logic for worker * Update cargo lock * Create thumbnail job example * Add job manager to context and prune context struct. * General cleanup * nothing but scuff * roughing out scanner with new system * comment * little bit by little bit * Tweak scanner logic and add bench * WIP use criterion for benches * Benchmarks work! * WIP subtasks * WIP persist completed state and main run loop * WIP use new impl * WIP progress emitting * WIP convert thumbnail job * Push up last nights marathon * Live log viewer * Add migration * WIP get UI job tracking functional again * WIP cleanup and refactor * WIP pause/resume * WIP cleanup and refactor * Refactor, reorg, clean * Fix warning * WIP: start using jms thumbnail manager * Use the thumbnail manager during job * WIP impl for missing series_job task * WIP: consolidate * WIP: consolidate * Commit and push cleanup from last night, prep for experimental --------- Co-authored-by: Joseph Micheli <josephwmicheli@gmail.com>
* WIP: replace pnpm with yarn * Replace all pnpm usages * Fix emoji-mart error * Add missed generated types * fix yarn in CI * fix yarn in CI * fix yarn in CI * fix yarn in CI * fix yarn in CI
* Try fix dockerfile * Reduce platforms for experimental * Update base image
* adds expo project * adds ts * changes name * adds tailwindcss using nativewind * tsconfig fix * fixes monorepo paths * adds nativewind + connect screen + auth wip * connect + login wip * Adds redirect to home or connect depending on user state * formatting * connecting and logging into stump * pnpm magic * removes debug console logs * final poc * fix cyclic requires * add fixme comment * adds expo project * adds ts * changes name * adds tailwindcss using nativewind * tsconfig fix * fixes monorepo paths * adds nativewind + connect screen + auth wip * connect + login wip * Adds redirect to home or connect depending on user state * formatting * connecting and logging into stump * removes debug console logs * final poc * prettified a bunch of files * rebase on mobile-app * rebase * adds nativewind + connect screen + auth wip * connect + login wip * chore(dev): loosen pre-commit hook * completed migration to primitive components * 128 appropriate routing setup eg tabs and stack navigators (stumpapp#130) * log in goes back to connect. Home does NOT go back to log in. * Fixes login screen push path * from settings can go back to home * Adds logout in the settings * Miscellaneous UI fixes on Phones and Tablets * UI Fixes + media support * WIP: get mobile app working * almost have something usable * AH * kicking screaming crying sobbing pooping * very basic stack navigation, framework for building first app release * WIP local storage alternative * Revert "WIP local storage alternative" This reverts commit 4b2d422. * Try (and fail) to fix zustand for RN * fix zustand? 🙏 * Created basic tab navigation with icons for mobile app * messing around * created navigation from libraries -> series -> books * Add wrapper Link and example hook usage * Add some supporting components * Generalizing some components and routes * added support for comic reader on android + started supporting landscape mode * continued development on explore/library pages * added barebones appearance settings * fix lints --------- Co-authored-by: Daniele Cambi <dancam.dev@gmail.com> Co-authored-by: Daniele Cambi <43640732+dancamdev@users.noreply.github.com>
* WIP: vertical scroll reader and full epub search * Quick fixes from regressions introduced by stumpapp#271 * ✨ Search entire EPUB text stumpapp#269 * WIP: toolbar for vertical reader, incognito reading * Search results with chapter info, misc cleanup * Fix merge imports
* Add discord notification for experimental build * WIP: unify image-based readers a bit * Stylistic tweaks * Fix Yomu reader * Improve preloading options Relates to stumpapp#210 * Touchups
…#286) * Fix dead docs links * WIP explorer refactor * WIP explorer refactor, focus on styles * 📱 Redesign file explorer and isolate to shared component Also some bug fixes and optimizations * Fix clippy lint
Reorganized a bit of the reader screen to account for future readers a bit better, and added a really bare-bones EPUB reader. This frankly will not hold up in time, IMO, and I'll likely either have to move off of epubjs in favor of an alternative that works well with RN or just build something in house.
* WIP findings and fixes Added new config for live refetch * Update docs a little * Migration * ✨ Additional EPUB metadata * Small fixes, adjust settings routing * Fix clippy lint
An enormous amount of changes incoming, currently what is on the `experimental` tag that will be the new `nightly` shortly. I'm on a bug hunt of sorts, and will leave this PR in draft until I feel more confident. A brief overview: - PNPM -> Yarn - Scanner rewrite - Hide libraries from specific users - Search full text in EPUB - Vertical continuous scrolling - Redesign the file explorer and integrate it into more places - Basic RN app functional!
* New translations en.json (Chinese Simplified) * New translations en.json (Romanian) * New translations en.json (French) * New translations en.json (Spanish) * New translations en.json (Afrikaans) * New translations en.json (Arabic) * New translations en.json (Catalan) * New translations en.json (Czech) * New translations en.json (Danish) * New translations en.json (German) * New translations en.json (Greek) * New translations en.json (Finnish) * New translations en.json (Hebrew) * New translations en.json (Hungarian) * New translations en.json (Italian) * New translations en.json (Japanese) * New translations en.json (Korean) * New translations en.json (Dutch) * New translations en.json (Norwegian) * New translations en.json (Polish) * New translations en.json (Portuguese) * New translations en.json (Russian) * New translations en.json (Serbian (Cyrillic)) * New translations en.json (Swedish) * New translations en.json (Turkish) * New translations en.json (Ukrainian) * New translations en.json (Chinese Traditional) * New translations en.json (Vietnamese) * New translations en.json (Portuguese, Brazilian) * New translations en.json (French) * New translations en.json (French) * New translations en.json (French) * New translations en.json (Romanian) * New translations en.json (French) * New translations en.json (Spanish) * New translations en.json (Afrikaans) * New translations en.json (Arabic) * New translations en.json (Catalan) * New translations en.json (Czech) * New translations en.json (Danish) * New translations en.json (German) * New translations en.json (Greek) * New translations en.json (Finnish) * New translations en.json (Hebrew) * New translations en.json (Hungarian) * New translations en.json (Italian) * New translations en.json (Japanese) * New translations en.json (Korean) * New translations en.json (Dutch) * New translations en.json (Norwegian) * New translations en.json (Polish) * New translations en.json (Portuguese) * New translations en.json (Russian) * New translations en.json (Serbian (Cyrillic)) * New translations en.json (Swedish) * New translations en.json (Turkish) * New translations en.json (Ukrainian) * New translations en.json (Chinese Simplified) * New translations en.json (Chinese Traditional) * New translations en.json (English) * New translations en.json (Vietnamese) * New translations en.json (Portuguese, Brazilian) * New translations en.json (Portuguese) * New translations en.json (Chinese Simplified) * New translations en.json (Chinese Traditional) * New translations en.json (Portuguese, Brazilian) * New translations en.json (German) * New translations en.json (German) * 🎨 Isolate `i18n` to separate package * New translations en.json (French) * New translations en.json (French)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds tests to the OPDS module in the core crate and is a step toward completing #281. The tests mainly validate XML, so further testing (e.g., of how
OpdsFeedstructs are created from library date) may be desired in the future.Additionally, it attempts to address a todo comment about the need for doc comments by adding comments to modules and structs describing them and linking to the relevant portion of the standard that they implement. Let me know if additional documentation is needed and I can add it.