Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blender 2.79 invalid syntax fix #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jayakusuma13
Copy link

replaced the colon ( : ) with equal sign ( = ) on line 35, line 41, and line 51

@stuffmatic
Copy link
Owner

Hello! This looks like the inverse of #9. Could you explain what this does, for what blender version(s) etc?

@jayakusuma13
Copy link
Author

Oh sorry i forgot to mention it. In my Blender 2.79b, the v1.0.3 version gave me an invalid syntax error, so i had to replace the colon with = sign to fix it.

@jayakusuma13 jayakusuma13 changed the title Blender invalid syntax fix Blender 2.79 invalid syntax fix Apr 16, 2020
@stuffmatic
Copy link
Owner

stuffmatic commented Apr 16, 2020

The syntax you introduce in this PR (and that was used previously in the add-on code) causes a deprecation warning in 2.80+. The point of merging #9 was to ensure compatibility with Blender 2.80 and beyond at the expense of support for earlier Blender versions. If you can find a way of solving this issue in a way that works for 2.79 without causing warnings/errors in 2.80+, then that would be very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants