Merge branch with master #2885
Open
Merge branch with master #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| post_data = Net::HTTP.post_form(URI.parse(mailgun_url), { | ||
| :from => "Student Insights job <kevin.robinson.0@gmail.com>", | ||
| :to => target_email, | ||
| :subject => "Weekly Reminder #{date_text}", |
There was a problem hiding this comment.
It might be a good idea to add "Student Insights" to the subject here
| .joins(:event_notes) | ||
| .joins(:homeroom) | ||
| .joins(:students) | ||
| .where("students.grade IN ('KF', '1', '2', '3', '4', '5', '6', '7', '8') AND event_notes.created_at >= now() - INTERVAL '7 DAYS' ") |
There was a problem hiding this comment.
3 comments here:
event_notes has a recorded_at field that we should use instead of created_at.
We'd also like to capture notes that were updated within the time period. The event_note model has a method latest_revision_at that I think would work here.
Also, should now() be @time_now?
|
This looks good, @trevorsaunders! We'll talk in a few minutes but in the meantime I left a couple comments. |
|
Thanks Eric!
Trevor Saunders
Systems Administrator
917.562.7501
Prophet
160 5th Avenue FL 5 New York, NY 10010
Prophet Thinking<https://prophet.com/thinking>
From: Eric Davidson-Sawyer ***@***.***>
Date: Wednesday, June 2, 2021 at 12:42 PM
To: studentinsights/studentinsights ***@***.***>
Cc: Trevor Saunders ***@***.***>, Mention ***@***.***>
Subject: Re: [studentinsights/studentinsights] Merge branch with master (#2885)
This looks good, @trevorsaunders<https://urldefense.com/v3/__https:/github.com/trevorsaunders__;!!MhCpU-uPy0U!33yAiSOk3m2KJgh53nO5xV5fUXx0EZR21PCTVIubVhPI81fXUvJhLMENKEjpwu5F$>! We'll talk in a few minutes but in the meantime I left a couple comments.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/studentinsights/studentinsights/pull/2885*issuecomment-853183271__;Iw!!MhCpU-uPy0U!33yAiSOk3m2KJgh53nO5xV5fUXx0EZR21PCTVIubVhPI81fXUvJhLMENKFGatjjn$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AAIKESTUAUPXEPAEX4Y6Y5LTQZNNTANCNFSM456VSY7A__;!!MhCpU-uPy0U!33yAiSOk3m2KJgh53nO5xV5fUXx0EZR21PCTVIubVhPI81fXUvJhLMENKHSkR2gz$>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
What problem does this PR fix?
What does this PR do?
Screenshot (if adding a client-side feature)
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?