Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace breakdown subtable by line spanning the whole table #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

voxik
Copy link
Contributor

@voxik voxik commented Dec 20, 2023

The nested tables do not work satisfactory.

Mainly, there seem to be issues with properly computing the headers widht, which sometime are wrapped, while there is sill plenty of space.

Secondly, the lenght of break down line is quite limited, while it does not really harm if it exceeds to the nehboring colum. Even if that was problem, the entered text can be wrapped to multiple lines.

Given these limitations, it is better to emulate single entries by multiple lines, where the firs line, which contains the important information is split into the columns, while the breakdown spans the whole table.

@voxik voxik changed the title Replace breakdown subtable by line spanning the whole table [WIP] Replace breakdown subtable by line spanning the whole table Dec 20, 2023
@voxik
Copy link
Contributor Author

voxik commented Dec 20, 2023

Marking this WIP, because I have not even attempted to execute the test suite, sorry 🙈

@voxik
Copy link
Contributor Author

voxik commented Dec 20, 2023

There are some caveats. For example czech_invoice_long.pdf is different dues to the stripping:

a

The original stripping code begins the first line with the first color. This version cannot assure this, because there is enough information to reset the stripping. But so far, I'd say this could be neglected. Actually, I don't know how the breakdown would be originally handled should it be on the page break ...

@voxik
Copy link
Contributor Author

voxik commented Dec 20, 2023

Other then that, there is a small difference only in the breakdown.pdf, which is kind of expected:

breakdown

I'll keep working on this soon ...

The nested tables do not work satisfactory.

Mainly, there seem to be issues with properly computing the headers
widht, which sometime are wrapped, while there is sill plenty of space.

Secondly, the lenght of break down line is quite limited, while it does
not really harm if it exceeds to the nehboring colum. Even if that was
problem, the entered text can be wrapped to multiple lines.

Given these limitations, it is better to emulate single entries by
multiple lines, where the firs line, which contains the important
information is split into the columns, while the breakdown spans the
whole table.
@voxik
Copy link
Contributor Author

voxik commented Dec 22, 2023

This is for comparison of the original / new with extra long breakdown line

original / new

@voxik
Copy link
Contributor Author

voxik commented Dec 22, 2023

I have included the modified test files with the changes as elaborated above. Removing the WIP

@voxik voxik changed the title [WIP] Replace breakdown subtable by line spanning the whole table Replace breakdown subtable by line spanning the whole table Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant