Combine purchaser_name together with purchaser_lines #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quite often the purchaser name looks like: ~~~ John Doe, Foo Inc. ~~~ Where the invoice is prepared for John Doe from Foo Inc. company. If this is the case, the `purchaser_name` becomes too long and ovelaps the `purchaser_lines. The overlapping can be avoided by combining the `purchaser_name` and `purchaser_lines`, outputting just the first line in bold and treating the rest just as an address. This should provide the greatest flexibility and it is actually extension to strzibny#77.
|
I like the idea. Maybe the provider should be treated the same? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite often the purchaser name looks like:
Where the invoice is prepared for John Doe from Foo Inc. company. If this is the case, the
purchaser_namebecomes too long and ovelaps the `purchaser_lines.The overlapping can be avoided by combining the
purchaser_nameandpurchaser_lines, outputting just the first line in bold and treating the rest just as an address. This should provide the greatest flexibility and it is actually extension to #77.Before:
After: