Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem that the test projects are not being enriched by VsTest. #2751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MischaVreeburg
Copy link
Contributor

For the enrichment, an alternative datasource has been chosen along with some clever parsing. It now falls back for C# files to the previously scanned test source files and tries to map the test full name with the name in the file and uses that info to get the test file path, along with the method declaration.

This PR fixes issue: #2750

For the enrichment, an alternative datasource has been chosen along with some clever parsing.
It now falls back for C# files to the previously scanned test source files and tries to map the test full name with the name in the file and uses that info to get the test file path, along with the method declaration.
@dupdob
Copy link
Member

dupdob commented Nov 4, 2023

Thanks for this PR. This is not a review but a bunch of general comments:

  1. you need to add unit tests for this. I suggest isolating the source code searching/parsing algorithm so writing test is easier
  2. note that this approach provides only partial support: unit tests can be renamed via framework specific attributes and theory-like tests may include data as part of their name.

Overall, I think this is a good move, but I would like feedback from the core team regarding if this is an approach they support (i.e. this simply improving and supporting it until a fix from VsTest teams is made available)

@rouke-broersma
Copy link
Member

@dupdob sounds good to me, I have no objection and I agree with your review feedback as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants