vici: add asynchronous session in python module #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 3 alerts when merging d5167d8 into 1b21a00 - view on LGTM.com new alerts:
|
|
You missed the opportunity to call it |
jeanseb6wind
force-pushed
the
add_async_2
branch
from
d5167d8
to
0e6ef3a
Compare
|
Hello, Thanks |
Add a new Python 3.6 package allowing vici to send asynchronous requests. This feature is only available in Python 3 so we add a condition in the setup.py in order to not break the Python 2 package.
jeanseb6wind
force-pushed
the
add_async_2
branch
from
0e6ef3a
to
0baac0b
Compare
|
It's been 4 months. Looks like you could make a fork project. I'd suggest you name it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Python 3.6 package allowing vici to send asynchronous
requests. This feature is only available in Python 3 so we add a
condition in the setup.py in order to not break the Python 2 package.