Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace destroy in the failed SA with DESTROY_IF #1488

Open
wants to merge 1 commit into
base: ikev2-qske-multi-ke
Choose a base branch
from

Conversation

TNLTom
Copy link

@TNLTom TNLTom commented Jan 3, 2023

On testing, we get random segfaults on this particular destroy call. I can't really reproduce it but replacing the destroy call with DESTROY_IF should not hurt and since then we have not seen the segfault anymore.

On testing, we get random segfaults on this particular destroy call.
I can't really reproduce it but replacing the destroy call with
DESTROY_IF should not hurt and since then we have not seen the
segfault anymore.
@tobiasbrunner
Copy link
Member

You should investigate when this happens exactly, because there should not be a call to this function with this->child_sa being NULL. It's called from process_i* implementations, that is, after build_i, which always allocates this->child_sa (and that can't have failed as there would have been a crash earlier). So there has to be some other issue here. What failure triggers the call to delete_failed_sa()?

Also note that the ikev2-qske-multi-ke branch will not be developed any further, the current branch with multi-KE support is six-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants