Keys are not being parsed has ObjectId

[cossou]

Hi guys,

I have the following scenario.
I made a GET to the following address: /accounts/{id}/apps/{fk}

With the id and fk
id: 54dc9dec466d681300289184
fk: 550715659866120300128497 (ObjectId but its also Integer)

I'm using Mongo and both id and fk were auto generated.

The result from the API:

{
  "error": {
    "name": "Error",
    "status": 404,
    "message": "No instance with id 5.507156598661203e+23 found for App",
    "statusCode": 404
  }
}

My App model:

{
  "name": "App",
  "plural": "apps",
  "base": "PersistedModel",
  "idInjection": true,
  "properties": {
    "name": {
      "type": "string",
      "required": true
    },
    "appId": {
      "type": "string",
      "required": false,
      "index": {
        "unique": true
      }
    },
    "active": {
      "type": "boolean",
      "default": true
    },
    "created": {
      "type": "date"
    },
    "modified": {
      "type": "date"
    }
  },
  "validations": [],
  "relations": {
    "account": {
      "type": "belongsTo",
      "model": "Account",
      "foreignKey": ""
    }
  },
  "acls": [],
  "methods": []
}

[raymondfeng]

@ritch strong-remoting is confused by the special MongoDB object id literal (550715659866120300128497) and parses it into a number. Unfortunately, the number loses the precision and it cannot be formatted as hex to test the object id pattern.

[ritch]

Strong-remoting needs to know what type it should use for those arguments. Since it isn't explicit it tries to convert it to an integer (since it looks like one).

You can be explicit about the type by modifying the accepts array for the SharedMethod. You can get the shared method using MyModel.sharedClass.find(). See these links for more:

http://apidocs.strongloop.com/strong-remoting/#sharedmethod
http://apidocs.strongloop.com/strong-remoting/#sharedclass-prototype-find
http://apidocs.strongloop.com/strong-remoting/#sharedclass-prototype-methods

[raymondfeng]

At the moment, the fk argument is typed as any. See https://github.com/strongloop/loopback/blob/master/lib/model.js#L497-L499.

[cossou]

@raymondfeng & @ritch Thanks!

Can I force the type in the .json?

[ritch]

At the moment, the fk argument is typed as any

I wonder if we can set that to string if we know that the dataSource is going to use string-ish IDs.

[cossou]

@ritch @raymondfeng Is there a simpler way to force the fk to string.

Wondering why no one else run into this problem before.

[kblcuk]

Currently the fix causes problems with auto-generated ids for Mongo -- loopback now tries to force datatype to number if id is not explicitly defined in model definition file, whereas before (current HEAD) it let Mongo to decide what datatype id should be.

So GETting /api/myModel/550be5c213cd775eb14e7edb throws id must be a number.

[seriousben]

Could the mongo connector provide a new type? This would be very useful in a lots of situations.

Would be nice to also find a solution fixing id comparison with a param, right now we always need to cast the Id to string.