Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote the UseKRaft feature gate to GA #10106

Merged
merged 3 commits into from
May 16, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented May 14, 2024

Type of change

  • Task

Description

In line with the Strimzi Proposal 62, this PR moves the UseKRaft to GA. It removes it from the code and keeps it permanently enabled.

Note: This does not mean KRaft is used by default as it still needs to be enabled with the strimzi.io/kraft: enabled feature gate. There is just no feature gate anymore.

There are two tasks that might be done in separate PRs as follow-ups:

  • The KRaft based ST in the FeatureGatesST class seems useful, but not sure it makes sense to keep it in the Feature Gates tests
  • The documentation might use further improvements to make KRaft moe prominent also outside of the feature gate description as the list of limitations for example might get a bit lost now.

Checklist

  • Make sure all tests pass
  • Update documentation
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Update CHANGELOG.md

@scholzj scholzj added this to the 0.42.0 milestone May 14, 2024
@scholzj
Copy link
Member Author

scholzj commented May 14, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented May 14, 2024

/azp run migration

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented May 14, 2024

/azp run kraft-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented May 15, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@scholzj
Copy link
Member Author

scholzj commented May 15, 2024

/azp run feature-gates-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented May 15, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj force-pushed the promote-UseKRaft-feature-gate-to-GA branch from 4290421 to d3ec232 Compare May 15, 2024 22:10
Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good. Just a couple of minor suggestions.

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj merged commit 8926cba into strimzi:main May 16, 2024
13 checks passed
@scholzj scholzj deleted the promote-UseKRaft-feature-gate-to-GA branch May 16, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants