Make CC port configurable in KafkaRebalanceAssemblyOperator #10096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
fvaleri
requested review from
ppatierno and
scholzj
and removed request for
ppatierno
|
@fvaleri why there was the need to make the CC port configurable? Just a genuine question ... maybe tests were failing with the default CC port not free and the need to find a free one? I haven't never seen a failure for that. |
In general, CC "standard" port (9090) is fairly common, and could be already in use by another process on your machine. This change avoids this potential port conflict, and makes these tests more robust. It's already implemented that way in other tests. |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
reviewed
May 15, 2024
.../main/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperator.java
Show resolved
Hide resolved
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
scholzj
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this PR comment.