feat: add legacy sign-in #2035
feat: add legacy sign-in #2035
Conversation
whitmanschorn
changed the title
|
@whitmanschorn Please format your branch name in the proper convention. See here: https://streetmix.readthedocs.io/en/latest/contributing/code/#submitting-a-pull-request It is |
| @@ -77,6 +77,14 @@ export function goGoogleSignIn () { | |||
| }) | |||
| } | |||
|
|
|||
| export function goPasswordSignIn () { | |||
There was a problem hiding this comment.
The call to goPasswordSignIn includes a locale parameter, but this does not receive it or do anything with it.
| return <button onClick={handleClick}>Auth0 Sign-In</button> | ||
| } | ||
|
|
||
| export default SignInButton |
There was a problem hiding this comment.
Actually, this component is never used anywhere. Why is it included?
There was a problem hiding this comment.
Looks like it's meant to generate the button used here. I'm going to commit a change that makes this actually happen.
|
@easherma Yes, this is related to that issue. I'd have preferred that the sign in process be part of the Streetmix UI and not a separate page, but even if we were to keep it on a separate page we'd have to do a design review on the look and feel. This is actually of extremely high importance because there are entire categories of people who are blocked from signing in right now. Enabling email + password login will alleviate some of the problem but we still don't know why passwordless emails are blocked right now. |
easherma
force-pushed
the
feat/password_login
branch
from
86ff451
to
35fe6b0
Compare
WIP change to allow users to use Auth0 dedicated login page, which includes username/password login.
✅ i18n with locale passed from streetmix
✅ password reset
✅ new account creation
🛑 No design approval. Once we have finalized design, we will update the snapshot for the relevant test.