Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: fix(407): add crc to wal entry #425

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WIP: fix(407): add crc to wal entry #425

wants to merge 2 commits into from

Conversation

lsytj0413
Copy link
Contributor

Fixed：#407

First implement of add crc to wal entry, currently there is a lot of work should be done:

  • Implement crc reset in TruncateLog
  • validate crc value when read data
  • add decoder to simplify code
  • add examples

and so on.

@lsytj0413 lsytj0413 force-pushed the fix-407 branch 3 times, most recently from 5d067fe to 93deb32 Compare January 5, 2024 01:47
@lsytj0413
fix(407): add crc to wal entry
9f36e36 
Signed-off-by: Soren Yang <lsytj0413@gmail.com>
@lsytj0413
fix(407): add crc to wal entry
64df45f 
Signed-off-by: Soren Yang <lsytj0413@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat Awaiting requested review from merlimat merlimat is a code owner

@mattisonchao mattisonchao Awaiting requested review from mattisonchao mattisonchao is a code owner

@coderzc coderzc Awaiting requested review from coderzc coderzc is a code owner

@RobertIndie RobertIndie Awaiting requested review from RobertIndie RobertIndie is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lsytj0413