Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Feature】add crc to wal #407

Open
lsytj0413 opened this issue Dec 12, 2023 · 5 comments
Open

【Feature】add crc to wal #407

lsytj0413 opened this issue Dec 12, 2023 · 5 comments
Assignees

Comments

@lsytj0413
Copy link
Contributor

oxia use wal to storage the LogEntry in segment files, should we add crc to each record to protect data corrupted?

@merlimat
Copy link
Collaborator

Yes, one idea was to use a crc based on the past entries of the log as well. (eg: similar to git history). That would help in identifying any issues in non-common histories of the wal across nodes.

@lsytj0413
Copy link
Contributor Author

/assign

@merlimat
Copy link
Collaborator

@lsytj0413 Perhaps we can start with a proposal and design doc for how to implement the change. We can use discussions. eg: https://github.com/streamnative/oxia/discussions/new?category=proposal

@lsytj0413
Copy link
Contributor Author

@lsytj0413 Perhaps we can start with a proposal and design doc for how to implement the change. We can use discussions. eg: https://github.com/streamnative/oxia/discussions/new?category=proposal

Yes, i will open an proposal to describe the detail design first.

@lsytj0413
Copy link
Contributor Author

lsytj0413 commented Dec 27, 2023

@lsytj0413 Perhaps we can start with a proposal and design doc for how to implement the change. We can use discussions. eg: https://github.com/streamnative/oxia/discussions/new?category=proposal

Propocal at #412 ,PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants