Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Release bytebuf when exception occur. #900

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix - Release bytebuf when exception occur. #900

wants to merge 2 commits into from

Conversation

casuallc
Copy link
Contributor

@casuallc casuallc commented May 9, 2023

Motivation

Release bytebuf when exception occur.

Modifications

Verifying this change

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • no-need-doc

@github-actions github-actions bot added the no-need-doc This pr does not need any document label May 9, 2023
gaoran10
gaoran10 previously approved these changes Jun 28, 2023
View reviewed changes
@gaoran10
Copy link
Collaborator

Sorry for the late response, could you check the checkstyle problem?

@casuallc
Copy link
Contributor Author

Done. @gaoran10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoran10 gaoran10 gaoran10 left review comments

@codelipenghui codelipenghui Awaiting requested review from codelipenghui codelipenghui is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@casuallc casuallc

Labels
no-need-doc This pr does not need any document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@casuallc @gaoran10