Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Add permit if receive nack command. #899

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

casuallc
Copy link
Contributor

@casuallc casuallc commented May 8, 2023

Motivation

Add permit if receive nack command.

The availablePermits will reduce when resend message to consumer.

Modifications

Verifying this change

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • no-need-doc

@github-actions github-actions bot added the no-need-doc This pr does not need any document label May 8, 2023
@casuallc
Copy link
Contributor Author

casuallc commented May 8, 2023

Please take a look. @gaoran10 @mingyifei

@GhostBoyBoy
Copy link
Contributor

Please take a look. @gaoran10 @mingyifei

availablePermits are processed at the time of consumption.

@casuallc
Copy link
Contributor Author

casuallc commented May 9, 2023

availablePermits are processed at the time of consumption.

CreditManager done not work.

You can try it.
When consumer client send nack command, broker will resend message and decrease availablePermits, after 1000 times sended, will blocked.
@mingyifei

@GhostBoyBoy
Copy link
Contributor

availablePermits are processed at the time of consumption.

CreditManager done not work.

You can try it. When consumer client send nack command, broker will resend message and decrease availablePermits, after 1000 times sended, will blocked. @mingyifei

ok, you can test the multi-bundle implementation, the previous version will be deprecated in the future.

@GhostBoyBoy
Copy link
Contributor

availablePermits are processed at the time of consumption.

CreditManager done not work.

You can try it. When consumer client send nack command, broker will resend message and decrease availablePermits, after 1000 times sended, will blocked. @mingyifei

AmqpMultiBundlesChannel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants