Fix - New add queue should not previously sent message. #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
reviewed
Jun 28, 2023
| @@ -297,7 +297,7 @@ private CompletableFuture<ManagedCursor> createCursorIfNotExists(String name) { | |||
| if (log.isDebugEnabled()) { | |||
| log.debug("Create cursor {} for topic {}", name, persistentTopic.getName()); | |||
| } | |||
| ledger.asyncOpenCursor(name, CommandSubscribe.InitialPosition.Earliest, | |||
There was a problem hiding this comment.
Sorry for the late response, if the queue is added the first time, we can set the position to Latest , if the queue is added due to recovery, we need to set the position to Earliest, or messages which are not routed completely, not routing messages may be lost.
There was a problem hiding this comment.
The cursor would be add when queue added, and delete after queue deleted or unbind.
I'm not sure why the cursor created when queue recovery?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
New add queue can only receive message that send after queue add to exchange.
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc