Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for AoP #623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gaoran10
Copy link
Collaborator

@gaoran10 gaoran10 commented Jul 24, 2022

Motivation

Currently, there are no metrics for AoP, it's hard to monitor AoP status. This PR will add metrics for AoP.

Modifications

Add below metrics for AoP.

MetricsLabel Description Labels
vhost_count vhost count cluster
exchange_count exchange count cluster, vhost
queue_count queue count cluster, vhost
amqp_connection_counter amqp connection count cluster, vhost
exchange_write_counter exchange write count cluster, vhost, exchange_name
exchange_write_failed_counter exchange write failed count cluster, vhost, exchange_name
exchange_read_counter exchange read count cluster, vhost, exchange_name
exchange_read_failed_counter exchange read failed count cluster, vhost, exchange_name
exchange_ack_counter exchange ack count cluster, vhost, exchange_name
exchange_route_counter exchange route count cluster, vhost, exchange_name
exchange_route_failed_counter exchange route failed count cluster, vhost, exchange_name
queue_write_counter queue write count cluster, vhost, queue_name
queue_write_failed_counter queue write failed count cluster, vhost, queue_name
queue_dispatch_counter queue dispatch count cluster, vhost, queue_name
queue_read_failed_counter queue read failed count cluster, vhost, queue_name
queue_ack_counter queue ack count cluster, vhost, queue_name

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@github-actions
Copy link

@gaoran10:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Jul 24, 2022
@github-actions
Copy link

@gaoran10:Thanks for providing doc info!

@github-actions github-actions bot added doc-required This pr needs a document and removed doc-info-missing This pr needs to mark a document option in description labels Jul 24, 2022
@ronfarkash
Copy link

Hey, bumping this. Metrics for AoP would be very useful for a lot of users!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required This pr needs a document release/2.10.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants