Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecation notice #879

Merged
merged 1 commit into from
May 8, 2024
Merged

fix deprecation notice #879

merged 1 commit into from
May 8, 2024

Conversation

xyephy
Copy link
Contributor

@xyephy xyephy commented Apr 30, 2024

This PR updates GitHub action workflow to Node.js 20 and also fixes deprecation warnings in #865.

@xyephy xyephy changed the title fix deprecation notice #865 fix deprecation notice Apr 30, 2024
Copy link
Contributor

@NonsoAmadi10 NonsoAmadi10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavlenex pavlenex linked an issue May 1, 2024 that may be closed by this pull request
@Fi3 Fi3 deleted the branch stratum-mining:dev May 3, 2024 09:37
@Fi3 Fi3 closed this May 3, 2024
@Fi3 Fi3 reopened this May 3, 2024
@Fi3
Copy link
Collaborator

Fi3 commented May 3, 2024

This PR needs to be rebased on dev

@xyephy
Copy link
Contributor Author

xyephy commented May 3, 2024

This PR needs to be rebased on dev

its now up to date with dev

@plebhash
Copy link
Collaborator

plebhash commented May 4, 2024

thanks @xyephy

were you able to dry-run these actions as a test?

@xyephy
Copy link
Contributor Author

xyephy commented May 6, 2024

thanks @xyephy

were you able to dry-run these actions as a test?

yes, they seem to run to completion without errors .

fix deprecation notice stratum-mining#865
@plebhash plebhash merged commit 2aa71f1 into stratum-mining:dev May 8, 2024
9 checks passed
@plebhash plebhash mentioned this pull request May 23, 2024
Fi3 pushed a commit that referenced this pull request May 28, 2024
@plebhash plebhash mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation notice: actions/checkout@v3, actions/upload-artifact@v3
4 participants