Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ARM architecture support on release-bin.yaml #864

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

xyephy
Copy link
Contributor

@xyephy xyephy commented Apr 19, 2024

PR fixes #815

@plebhash
Copy link
Collaborator

      - name: Install cross
        run: cargo install cross

why do we repeat this step so many times? Isn't it enough to do it 1x?

@xyephy
Copy link
Contributor Author

xyephy commented Apr 20, 2024

      - name: Install cross
        run: cargo install cross

why do we repeat this step so many times? Isn't it enough to do it 1x?

sorry, forgot to clean out the extras. Let me fix that repetition.

@plebhash
Copy link
Collaborator

@xyephy can you do another mock release on your fork to make sure the last changes didn't break anything?

I think we're ready to merge after that

@xyephy
Copy link
Contributor Author

xyephy commented Apr 23, 2024

      - name: Install cross
        run: cargo install cross

why do we repeat this step so many times? Isn't it enough to do it 1x?

I think this was the error that made me repeat it:

Run cross build --release --locked --manifest-path=roles/translator/Cargo.toml --target aarch64-unknown-linux-gnu
/home/runner/work/_temp/ad07bc1c-48f2-4f5c-9103-eae3b19d85f3.sh: line 1: cross: command not found
Error: Process completed with exit code 127.

@xyephy
Copy link
Contributor Author

xyephy commented Apr 23, 2024

@xyephy can you do another mock release on your fork to make sure the last changes didn't break anything?

I think we're ready to merge after that

here are the mock releases
https://github.com/xyephy/stratum/releases/tag/dev

@plebhash plebhash merged commit 721f7b1 into stratum-mining:dev Apr 24, 2024
9 checks passed
lorbax pushed a commit to lorbax/stratum that referenced this pull request Apr 25, 2024
* test Update release-bin.yaml

* add ARM architecture support on release-bin.yaml

* add linux ARM support for release-bin.yaml

* cleanup arm duplicates
lorbax pushed a commit to lorbax/stratum that referenced this pull request Apr 25, 2024
* test Update release-bin.yaml

* add ARM architecture support on release-bin.yaml

* add linux ARM support for release-bin.yaml

* cleanup arm duplicates
lorbax pushed a commit to lorbax/stratum that referenced this pull request May 2, 2024
* test Update release-bin.yaml

* add ARM architecture support on release-bin.yaml

* add linux ARM support for release-bin.yaml

* cleanup arm duplicates
plebhash pushed a commit that referenced this pull request May 2, 2024
* test Update release-bin.yaml

* add ARM architecture support on release-bin.yaml

* add linux ARM support for release-bin.yaml

* cleanup arm duplicates
Fi3 pushed a commit to Fi3/stratum-1 that referenced this pull request May 3, 2024
* test Update release-bin.yaml

* add ARM architecture support on release-bin.yaml

* add linux ARM support for release-bin.yaml

* cleanup arm duplicates
Fi3 pushed a commit to Fi3/stratum-1 that referenced this pull request May 3, 2024
* test Update release-bin.yaml

* add ARM architecture support on release-bin.yaml

* add linux ARM support for release-bin.yaml

* cleanup arm duplicates
Fi3 pushed a commit to Fi3/stratum-1 that referenced this pull request May 3, 2024
* test Update release-bin.yaml

* add ARM architecture support on release-bin.yaml

* add linux ARM support for release-bin.yaml

* cleanup arm duplicates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants