New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(translator): fix HexError(OddLength) in mining.subscribe handler #851
base: dev
Are you sure you want to change the base?
Conversation
Add a nicer user interface to the sv2 cpuminer with help messages. Add noise to the cpuminer.
Improve sv2 cpuminer
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
@nikicat haven't you added some tests? |
@GitGab19 This is because my initial fix turned out to be wrong - it was just a coincidence that a miner with an odd-sized extranonce stopped subscribing. |
I'm not following you. Are you saying there's no issue at all? |
There is an issue: when a miner sends |
Hi @nikicat ty for the patch. Can you also add a test that fail without the patch? |
Hi @Fi3 could you point me to a test where I can add a test case? Or confirm that I should write the test from scratch. |
@nikicat you can add an unit test in the v1 crate writing it from scratch is ok |
* test Update release-bin.yaml * add ARM architecture support on release-bin.yaml * add linux ARM support for release-bin.yaml * cleanup arm duplicates
cf60d5e
to
9965470
Compare
@Fi3 done |
Akn, test fails without this patch. Wait for another contributor to approve since now I don't have time for review it. |
Also remember to bump the patch version number in the translator and in the v1 lib |
This PR needs to be rebased on dev |
This PR fixes
ERROR translator_sv2::lib::status: Error: V1Protocol(Method(ParsingMethodError((HexError(OddLength), StandardRequest(StandardRequest { id: 150166, method: "mining.subscribe", params: Array [String("bmminer/2.0.0"), String("265800001")] })))))
errors.
I'm new to Rust and made this PR with the help of ChatGPT, so I'm not sure it's fully correct. Nevertheless, it fixes the actual error in my case.
This error happens when the miner sends an odd-sized extranonce.