-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split roles bin lib #821
Closed
Closed
split roles bin lib #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this PR supposed to be against main? |
no, just fixed for |
plebhash
force-pushed
the
split-roles-bin-lib
branch
from
March 29, 2024 17:03
42cd3cc
to
c18dfae
Compare
plebhash
force-pushed
the
split-roles-bin-lib
branch
4 times, most recently
from
March 29, 2024 20:20
a7d016a
to
6bc3c79
Compare
plebhash
force-pushed
the
split-roles-bin-lib
branch
from
March 30, 2024 00:52
6bc3c79
to
f7d96e9
Compare
plebhash
force-pushed
the
split-roles-bin-lib
branch
from
March 30, 2024 01:16
e4d1b43
to
6a96613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #820
as stated in #702, it is desirable to have some clear distinction between:
bin
)lib
)so we should split the roles workspace in two distinct directories, one for
lib
(APIs) and one forbin
(executable applications).a
*_bin
suffix was added to the name of binary crates (to avoid name clash), which now have the following names:jd_client_sv2_bin
(also added_sv2
for consistency with other roles)jd_server_sv2_bin
(also added_sv2
for consistency with other roles)proxy_sv2_bin
(removedmining_
from the beginning to avoid redundancy)pool_sv2_bin
translator_proxy_sv2_bin
(added_proxy
to make it clear this is another kind of proxy)library crates now have the following names:
jd_client_sv2
(added_sv2
for consistency with other roles)jd_server_sv2
(added_sv2
for consistency with other roles)proxy_sv2
(removedmining_
from the beginning to avoid redundancy)network_helpers_sv2
pool_sv2
rpc_sv2
translator_proxy_sv2
(added_proxy
to make it clear this is another kind of proxy)config-examples
only exist for binary cratesmain.rs
andargs.rs
only exist for binary crateslib.rs
(+ all other internal logic) only exist for library crates