-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve sv2 cpuminer #819
Improve sv2 cpuminer #819
Conversation
@@ -143,7 +226,7 @@ pub struct Device { | |||
fn open_channel() -> OpenStandardMiningChannel<'static> { | |||
let user_identity = "ABC".to_string().try_into().unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ABC
could be made into a CLI arg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep I will do
93f7251
to
7c96c4e
Compare
@@ -209,7 +308,7 @@ impl Device { | |||
|
|||
loop { | |||
let mut incoming: StdFrame = receiver.recv().await.unwrap().try_into().unwrap(); | |||
let message_type = incoming.get_header().unwrap().msg_type(); | |||
let message_type = dbg!(incoming.get_header().unwrap().msg_type()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this dbg! is supposed to be here?
I reviewed the code and LGTM.
I also tested the --address option, by launching the pool listening on a different address
which works as expected.
|
Thanks for opening this! Added to my test list... |
ec44dae
to
b570b22
Compare
Add a nicer user interface to the sv2 cpuminer with help messages. Add noise to the cpuminer.
I was able to mine a block! Followup suggestions (feel free to merge this first, if it's holding back other things): Use all CPU threads (currently only uses 1). Rather than Perhaps simpler:
However that can wait for a followup. |
let id: u32 = 10; | ||
println!("MINING DEVICE: send open channel with request id {}", id); | ||
info!("Misuring pc hashrate"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Measuring
For the second block (on a custom signet) I'm getting errors:
|
Add a nicer user interface to the sv2 cpuminer with help messages. Add noise to the cpuminer.
This is the output of
cargo run -- --help