-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #784 #789
Closes #784 #789
Conversation
…async flow - Removed the unnecessary use of tokio::task::spawn in update_mempool, leveraging the existing async function context for all operations. - Renamed get_raw_mempool_verbose to get_raw_mempool to align with the underlying RPC call. - Streamlined error handling by removing .map_err(JdsMempoolError::TokioJoin) since separate async task spawning is no longer used. - Simplified control flow with direct return statements for error cases and inline error handling for lock operations. This refactor improves the readability and efficiency of the update_mempool function and aligns the code with best practices for async operations in Rust.
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Hi @pavlenex i think i might need help with passing the MG test. I have been able to fix everything else but this one seems like a constant fail for me. I appreciate your insight in advance |
I think it is still failing. I don't know if it is something I am missing on my part |
Afair this test is flaky. Let's see what experts have to say. For now I can only post logs
|
Everything is up and running on our VPS. |
as described in issue stratum-mining#777, we should replace every generic *(_) with specific errors and cover every possible combination
…, get them from jds mempool when a block is found
As suggested in stratum-mining#772 (comment) A task that before was blocking now is moved as a separate task on main
As suggested in stratum-mining#772 (comment) This commit introduces a verification that all the transactions in a job are correctly recognized when a submit block message appears.
Error management when some transactions are missing. The jds should not break. Instead, tries to recover it by triggering the jds mempool to retrieve the transactions from its bitcoin node
In the message handler the message the triggers the JDS mempool to fill the transactions is implemented in a bad way. Now it is fixed Add some documentation
apply Fi3 suggestion GitGab19#16 (comment)
93f7251
to
7c96c4e
Compare
I would be closing this PR because I don't want to force push and reimplementing this again. Thanks |
What does this PR do?
Refractor update_mempool module in JDS mempool module for simplified async flow