Replaces PR #727 #733
Merged
Replaces PR #727 #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 25, 2024
Fi3
reviewed
Jan 26, 2024
| error_code: SubmitSharesError::invalid_job_id_error_code() | ||
| .to_string() | ||
| .try_into() | ||
| .unwrap(), |
There was a problem hiding this comment.
add a comment that exaplain why the unwrap is safe
There was a problem hiding this comment.
I agree.
Going forward, IMO we should try to keep some discipline around the usage of unwrap, because we are getting some criticism from the community.
for example: #723 (comment)
Fi3
reviewed
Jan 26, 2024
| @@ -244,21 +243,33 @@ impl Downstream { | |||
| || (hashrate_delta_percentage >= 30.0) && (delta_time >= 240) | |||
| || (hashrate_delta_percentage >= 15.0) && (delta_time >= 300) | |||
| { | |||
| if realized_share_per_min < 0.01 { | |||
| if realized_share_per_min == 0.0 { | |||
There was a problem hiding this comment.
this is a float are you sure that is safe to change from < to ==
If yes write a comment that explain why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #712, #730