Use correct encoding for public secp256k1 key #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjors
reviewed
Jan 22, 2024
|
Don't forgot to update the branch to main. |
jakubtrnka
force-pushed
the
key-encoding
branch
from
40be044
to
d90bb98
Compare
|
I can test this against the Template Provider when #717 is fixed. But feel free to merge earlier. |
jakubtrnka
force-pushed
the
key-encoding
branch
from
f113a69
to
f3c06da
Compare
jakubtrnka
commented
Feb 6, 2024
jakubtrnka
commented
Feb 6, 2024
jakubtrnka
force-pushed
the
key-encoding
branch
5 times, most recently
from
f2764fc
to
669a5f1
Compare
|
LGTM only cargo fmt and tests to fix, I will open a PR with the fixes against @jakubtrnka branch |
jakubtrnka
force-pushed
the
key-encoding
branch
from
b6af360
to
537303e
Compare
|
| Report | Tue, February 13, 2024 at 17:49:38 UTC |
| Project | Stratum v2 (SRI) |
| Branch | key-encoding |
| Testbed | sv2 |
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) |
|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 44.116 |
| client_sv2_handle_message_mining | ✅ (view plot) | 64.566 |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 14.649 |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 254.260 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 600.000 |
| client_sv2_open_channel | ✅ (view plot) | 163.890 |
| client_sv2_open_channel_serialize | ✅ (view plot) | 289.990 |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 371.390 |
| client_sv2_setup_connection | ✅ (view plot) | 160.730 |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 501.540 |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 1028.700 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
| Report | Tue, February 13, 2024 at 17:49:37 UTC |
| Project | Stratum v2 (SRI) |
| Branch | key-encoding |
| Testbed | sv1 |
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Instructions | Instructions Results instructions | (Δ%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) |
|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | ✅ (view plot) | 8512.000 | ✅ (view plot) | 3746.000 | ✅ (view plot) | 5247.000 | ✅ (view plot) | 9.000 | ✅ (view plot) | 92.000 |
| get_submit | ✅ (view plot) | 95571.000 | ✅ (view plot) | 59439.000 | ✅ (view plot) | 85351.000 | ✅ (view plot) | 56.000 | ✅ (view plot) | 284.000 |
| get_subscribe | ✅ (view plot) | 7969.000 | ✅ (view plot) | 2841.000 | ✅ (view plot) | 3969.000 | ✅ (view plot) | 16.000 | ✅ (view plot) | 112.000 |
| serialize_authorize | ✅ (view plot) | 12277.000 | ✅ (view plot) | 5317.000 | ✅ (view plot) | 7407.000 | ✅ (view plot) | 15.000 | ✅ (view plot) | 137.000 |
| serialize_deserialize_authorize | ✅ (view plot) | 24514.000 | ✅ (view plot) | 9898.000 | ✅ (view plot) | 13954.000 | ✅ (view plot) | 40.000 | ✅ (view plot) | 296.000 |
| serialize_deserialize_handle_authorize | ✅ (view plot) | 30237.000 | ✅ (view plot) | 12101.000 | ✅ (view plot) | 17117.000 | ✅ (view plot) | 62.000 | ✅ (view plot) | 366.000 |
| serialize_deserialize_handle_submit | ✅ (view plot) | 126424.000 | ✅ (view plot) | 73224.000 | ✅ (view plot) | 104949.000 | ✅ (view plot) | 116.000 | ✅ (view plot) | 597.000 |
| serialize_deserialize_handle_subscribe | ✅ (view plot) | 27443.000 | ✅ (view plot) | 9643.000 | ✅ (view plot) | 13638.000 | ✅ (view plot) | 66.000 | ✅ (view plot) | 385.000 |
| serialize_deserialize_submit | ✅ (view plot) | 115011.000 | ✅ (view plot) | 68001.000 | ✅ (view plot) | 97556.000 | ✅ (view plot) | 68.000 | ✅ (view plot) | 489.000 |
| serialize_deserialize_subscribe | ✅ (view plot) | 22844.000 | ✅ (view plot) | 8195.000 | ✅ (view plot) | 11539.000 | ✅ (view plot) | 42.000 | ✅ (view plot) | 317.000 |
| serialize_submit | ✅ (view plot) | 99880.000 | ✅ (view plot) | 61483.000 | ✅ (view plot) | 88200.000 | ✅ (view plot) | 54.000 | ✅ (view plot) | 326.000 |
| serialize_subscribe | ✅ (view plot) | 11302.000 | ✅ (view plot) | 4188.000 | ✅ (view plot) | 5827.000 | ✅ (view plot) | 17.000 | ✅ (view plot) | 154.000 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
| Report | Tue, February 13, 2024 at 17:49:38 UTC |
| Project | Stratum v2 (SRI) |
| Branch | key-encoding |
| Testbed | sv2 |
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Instructions | Instructions Results instructions | (Δ%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) |
|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 2075.000 | ✅ (view plot) | 469.000 | ✅ (view plot) | 725.000 | ✅ (view plot) | 11.000 | ✅ (view plot) | 37.000 |
| client_sv2_handle_message_mining | ✅ (view plot) | 8111.000 | ✅ (view plot) | 2081.000 | ✅ (view plot) | 3066.000 | ✅ (view plot) | 43.000 | ✅ (view plot) | 138.000 |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 6382.000 | ✅ (view plot) | 1756.000 | ✅ (view plot) | 2552.000 | ✅ (view plot) | 24.000 | ✅ (view plot) | 106.000 |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 14737.000 | ✅ (view plot) | 4700.000 | ✅ (view plot) | 6762.000 | ✅ (view plot) | 48.000 | ✅ (view plot) | 221.000 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 27428.000 | ✅ (view plot) | 10543.000 | ✅ (view plot) | 15338.000 | ✅ (view plot) | 87.000 | ✅ (view plot) | 333.000 |
| client_sv2_open_channel | ✅ (view plot) | 4451.000 | ✅ (view plot) | 1461.000 | ✅ (view plot) | 2156.000 | ✅ (view plot) | 11.000 | ✅ (view plot) | 64.000 |
| client_sv2_open_channel_serialize | ✅ (view plot) | 14172.000 | ✅ (view plot) | 5064.000 | ✅ (view plot) | 7317.000 | ✅ (view plot) | 41.000 | ✅ (view plot) | 190.000 |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 22536.000 | ✅ (view plot) | 7979.000 | ✅ (view plot) | 11606.000 | ✅ (view plot) | 79.000 | ✅ (view plot) | 301.000 |
| client_sv2_setup_connection | ✅ (view plot) | 4799.000 | ✅ (view plot) | 1502.000 | ✅ (view plot) | 2269.000 | ✅ (view plot) | 16.000 | ✅ (view plot) | 70.000 |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 16240.000 | ✅ (view plot) | 5963.000 | ✅ (view plot) | 8655.000 | ✅ (view plot) | 47.000 | ✅ (view plot) | 210.000 |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 35482.000 | ✅ (view plot) | 14806.000 | ✅ (view plot) | 21752.000 | ✅ (view plot) | 93.000 | ✅ (view plot) | 379.000 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
| Report | Tue, February 13, 2024 at 17:49:41 UTC |
| Project | Stratum v2 (SRI) |
| Branch | key-encoding |
| Testbed | sv1 |
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) |
|---|---|---|
| client-submit-serialize | ✅ (view plot) | 6679.300 |
| client-submit-serialize-deserialize | ✅ (view plot) | 7609.000 |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | ✅ (view plot) | 8255.000 |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | ✅ (view plot) | 886.650 |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | ✅ (view plot) | 690.400 |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | ✅ (view plot) | 245.690 |
| client-sv1-get-authorize/client-sv1-get-authorize | ✅ (view plot) | 157.350 |
| client-sv1-get-submit | ✅ (view plot) | 6518.100 |
| client-sv1-get-subscribe/client-sv1-get-subscribe | ✅ (view plot) | 281.010 |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | ✅ (view plot) | 752.330 |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | ✅ (view plot) | 610.610 |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | ✅ (view plot) | 204.720 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
- Improve Display impl for key-util Error, add more error variants - Update format in key-util unit tests
- consequence of implementing Copy for secp256k1-keys types
jakubtrnka
force-pushed
the
key-encoding
branch
from
537303e
to
b8cf2db
Compare
|
@jakubtrnka some tests are failing with InvalidChecksum: |
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggested solution for #721