Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small bugs in the JDS mempool #784

Closed
lorbax opened this issue Mar 6, 2024 · 5 comments · Fixed by #833
Closed

small bugs in the JDS mempool #784

lorbax opened this issue Mar 6, 2024 · 5 comments · Fixed by #833
Assignees
Milestone

Comments

@lorbax
Copy link
Collaborator

lorbax commented Mar 6, 2024

Here
https://github.com/stratum-mining/stratum/blob/main/roles/jd-server/src/lib/mempool/mod.rs#L85
there is a tokio task that is awaited, which does not make any sense. Since the function update_mempool is already an async method, I think that the generation of a new task can be definitely can be avoided without any substantial work.

Also the rpc method get_raw_mempool_verbose should be renamed with get_raw_mempool, as at the end the rpc call is getrawmempool without verbose.

good for first issue!

@pavlenex pavlenex added the good first issue Good for newcomers label Mar 6, 2024
@NonsoAmadi10
Copy link

Hi @pavlenex i would love to take a go at this task, can I?

@pavlenex
Copy link
Collaborator

pavlenex commented Mar 9, 2024

Go for it!

@github-actions github-actions bot mentioned this issue Mar 11, 2024
NonsoAmadi10 added a commit to NonsoAmadi10/stratum that referenced this issue Mar 19, 2024
NonsoAmadi10 added a commit to NonsoAmadi10/stratum that referenced this issue Mar 20, 2024
@0xSaksham
Copy link

@pavlenex is this still open?

@NonsoAmadi10
Copy link

NonsoAmadi10 commented Mar 22, 2024

@0xSaksham I opened a PR for it. It is still in review. See it here #789

@pavlenex
Copy link
Collaborator

pavlenex commented May 8, 2024

Completed in #833

@pavlenex pavlenex closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants