New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small bugs in the JDS mempool #784
Comments
Hi @pavlenex i would love to take a go at this task, can I? |
Go for it! |
Closed
NonsoAmadi10
added a commit
to NonsoAmadi10/stratum
that referenced
this issue
Mar 19, 2024
NonsoAmadi10
added a commit
to NonsoAmadi10/stratum
that referenced
this issue
Mar 20, 2024
@pavlenex is this still open? |
@0xSaksham I opened a PR for it. It is still in review. See it here #789 |
Completed in #833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here
https://github.com/stratum-mining/stratum/blob/main/roles/jd-server/src/lib/mempool/mod.rs#L85
there is a tokio task that is awaited, which does not make any sense. Since the function
update_mempool
is already an async method, I think that the generation of a new task can be definitely can be avoided without any substantial work.Also the rpc method
get_raw_mempool_verbose
should be renamed withget_raw_mempool
, as at the end the rpc call isgetrawmempool
without verbose.good for first issue!
The text was updated successfully, but these errors were encountered: