Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-rnn-detection #453

Open
wants to merge 407 commits into
base: develop
Choose a base branch
from
Open

Fix-rnn-detection #453

wants to merge 407 commits into from

Conversation

eldraco
Copy link
Collaborator

@eldraco eldraco commented Feb 13, 2024

Fixes Issue

Closes #330

Changes proposed

  • Fix the RNN not working due to keras update (Bidirectional not loaded)
  • Add a new dataset to test the CC
  • Update the RNN model in Slips
  • Add new documentation of RRN and datasets

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

eldraco and others added 30 commits March 18, 2024 18:16
@eldraco
Update to clone from master
21719e8 
Signed-off-by: Sebastian Garcia <eldraco@gmail.com>
@eldraco
Merge pull request #488 from stratosphereips/m1-p2p-improve
8ce9f70 
Improve the docker creation for macos M1
@AlyaGomaa
idea_format: fix problem extracting attacker and victim's type
92fed9e
@AlyaGomaa
Merge pull request #489 from stratosphereips/alya/fix_idea_format
7be8339 
Fix problem extracting attacker and victim's type
@Sekhar-Kumar-Dash
Updated usage.md
30ccbd6
@Sekhar-Kumar-Dash
Update config_parser.py added description for analysis_direction
a1fcedb
@AlyaGomaa
CI-prod: no need to have a CI action for "test_slips_inside_docker" b…
39fbeec 
…ecause github CI is a container
@AlyaGomaa
ubuntu-image use COPY instead of git clone
b760ee9
@AlyaGomaa
init slips repo in the /Stratosphereips dir in docker
d8c281d
@AlyaGomaa
init slips repo in the /StratosphereIPS dir in docker
b34f189
@Sekhar-Kumar-Dash
fixed small typo in alert_handler.py
3282ef9
@Sekhar-Kumar-Dash
Updated slips.conf
23bef46
@AlyaGomaa
Update direction description slips.conf
26eca20
@AlyaGomaa
Merge pull request #491 from Sekhar-Kumar-Dash/master
eca90c9 
added description and comments on analysis_direction parameter in docs and config file [skip ci]
@AlyaGomaa
Merge pull request #494 from Sekhar-Kumar-Dash/patch-1
9fba76e 
fixed small typo in alert_handler.py
@AlyaGomaa
use the same docker dependencies in all images and compress the docke…
20bb661 
…rfiles
@AlyaGomaa
add pre-commit to requirements.txt
558473c
@AlyaGomaa
add detect-secrets pre-commit hook
ebc3ed6
@AlyaGomaa
contributing.md: add steps to install pre-hooks
5afb53c
@AlyaGomaa
p2p: delete unused imports
87beb9d
@AlyaGomaa
Add pre-commit hooks for trailing whitespace, dockstring after code, …
39f3585 
…detecting large file
@AlyaGomaa
add pre commit hook for double-quote-string-fixer
de96cc0
@AlyaGomaa
add a pre-hook to Analyze Python requirements for known security vuln…
f1c8e6a 
…erabilities
@AlyaGomaa
run black on slips
346466b
@AlyaGomaa
run ruff on slips
1ca0d2f
@AlyaGomaa
remove python-safety-dependencies-check hook
d334cfa
@AlyaGomaa
add black, ruff and pre-commit to requirements
2790e10
@AlyaGomaa
add ruff as a pre-hook
6645325
@AlyaGomaa
idea_format: fix problem extracting attacker and victim's type
72b2d8b
@Sekhar-Kumar-Dash @AlyaGomaa
Updated usage.md
1bc1c9f
eldraco and others added 30 commits April 20, 2024 18:52
@eldraco
rnn. Add the model v1.1
90698fb
@eldraco
docs. Move the plots to the docs folder
bb3f540
@eldraco
docs. Add the plots of v1 and v.11 to the docs folder
6e481b4
@eldraco
rnn. Add the original model
88a0d76
@eldraco
rnn. improve jupyter notebook
c10911e
@eldraco
rnn. Add optimization with optuna
8d1e438
@eldraco
Add log of the trials
089bc2c
@eldraco
Readme. include model v1.2
0ccf35d
@eldraco
add new model v1.2
b01c03d
@eldraco
readme. add graphs for model v1.2
9caef7a
@eldraco
ipynb. Improve code
d6e751c
@eldraco
rnn. New training python code
4c693e0
@eldraco
rnn. improve training algorithm outside ipynb
de25601
@eldraco
rnn. Delete old training file
808f4c7
@eldraco
rnn. train optuna for 500 trials
db5e544
@eldraco
Change the model to a new one optimized with Adam, not RMSProp
70a4195
@eldraco
Add verbosity 0
5a57983
@eldraco
Add comments
07cda11
@eldraco
Update the RNN model to v1.2
3661b6f
@eldraco
rnn. Add v1.4
ef85dd1
@eldraco
rnn. Fix v1.4
3e04f8f
@eldraco
rnn. Add model v1.4
283ffe4
@eldraco
rnn. Add model v1.4 plots
53efe76
@eldraco
rnn. Make the model v1.4 the default model for rnn
4607afc
@eldraco
Update README.md
6ec20cf
@eldraco
Update README.md
bd3a2f6
@AlyaGomaa
dependency_image: use python3.10
1086bb3
@AlyaGomaa
dependency_image: dont exclude black from requirements.txt
1fa5f08
@AlyaGomaa
dependency_image: remove tzlocal from requirements
ae1d45c
@AlyaGomaa
dependency_image: install python3-tzlocal and python3-certifi after i…
5149a71 
…nstaling python 3.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eldraco @AlyaGomaa @Sekhar-Kumar-Dash @zeyadtmi