Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start running metadata verification post-test checks #3618

Merged

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented May 14, 2024

@mulkieran mulkieran self-assigned this May 14, 2024
@mulkieran mulkieran added this to In progress (long term) in 2024May via automation May 14, 2024
@mulkieran mulkieran moved this from In progress (long term) to In progress in 2024May May 14, 2024
@mulkieran mulkieran marked this pull request as ready for review May 14, 2024 18:44
@mulkieran
Copy link
Member Author

Trivial unless it fails

Copy link

Cockpit tests failed for commit 05f1502. @martinpitt, @jelly, @mvollmer please check.

@mulkieran
Copy link
Member Author

Probably an anomalous failure for us...would be nice to improve test framework to give us a bit more, though.

@mulkieran
Copy link
Member Author

We should be retrying on the problem below:

  File "/var/ARTIFACTS/work-allf74mxjuq/plans/all/discover/default-0/tests/tests/client-dbus/tests/udev/test_udev.py", line 299, in test_encryption_simple_initial_discovery_with_takedown
    self._simple_initial_discovery_test(
  File "/var/ARTIFACTS/work-allf74mxjuq/plans/all/discover/default-0/tests/tests/client-dbus/tests/udev/test_udev.py", line 256, in _simple_initial_discovery_test
    wait_for_udev(STRATIS_FS_TYPE, get_devnodes(device_object_paths))
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/var/ARTIFACTS/work-allf74mxjuq/plans/all/discover/default-0/tests/tests/client-dbus/tests/udev/_utils.py", line 138, in get_devnodes
    Blockdev.Properties.Devnode.Get(get_object(op)) for op in device_object_paths
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/dbus_python_client_gen/_invokers.py", line 79, in dbus_func
    raise DPClientInvocationError(
dbus_python_client_gen._errors.DPClientInvocationError: Error while getting value for property "Devnode" belonging to interface "org.storage.stratis3.blockdev.r7"

not failing, since it is almost certainly just caused by not getting object paths on the D-Bus quite fast enough.

@mulkieran mulkieran moved this from In progress to Pending in 2024May May 20, 2024
@mulkieran
Copy link
Member Author

Blocked by stratis-storage/testing#259

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Copy link
Member Author

rebased

@mulkieran mulkieran moved this from Pending to In review in 2024May May 20, 2024
@mulkieran
Copy link
Member Author

We expect the tests to pass.

@mulkieran mulkieran merged commit 19bafdc into stratis-storage:master May 21, 2024
50 checks passed
2024May automation moved this from In review to Done May 21, 2024
@mulkieran mulkieran deleted the add-verify-pool-metadata branch May 21, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant