Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clevis pin tidies #1062

Closed
wants to merge 2 commits into from

Conversation

mulkieran
Copy link
Member

No description provided.

@mulkieran mulkieran self-assigned this Mar 18, 2024
@mulkieran mulkieran added this to In progress (long term) in 2024March via automation Mar 18, 2024
@mulkieran
Copy link
Member Author

rebased

@mulkieran
Copy link
Member Author

mulkieran commented Mar 27, 2024

Probably the solution to the problem of the incredibly messy Clevis configuration code, is to define a subclass of Action with a global object internally to store all the different Clevis stuff and then to define subclasses of that class for each possible option and then incrementally build that object as parser arguments are parsed. Even that is done, it will probably still be necessary to run a check in _main.py, just on the object produced by the parser rather than on individual namespace values.

@mulkieran mulkieran removed this from In progress (long term) in 2024March Apr 2, 2024
@mulkieran mulkieran added this to In progress (long term) in 2024April via automation Apr 2, 2024
@mulkieran
Copy link
Member Author

Should tidy up argument parsing first, probably.

@mulkieran
Copy link
Member Author

Blocked by #1073 .

@mulkieran mulkieran removed this from In progress (long term) in 2024April Apr 26, 2024
@mulkieran mulkieran added this to In progress (long term) in 2024May via automation Apr 26, 2024
@mulkieran mulkieran moved this from In progress (long term) to Pending in 2024May Apr 26, 2024
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran moved this from Pending to In progress (long term) in 2024May Apr 29, 2024
@mulkieran mulkieran closed this May 21, 2024
@mulkieran mulkieran deleted the clevis-pin-tidies branch May 21, 2024 16:35
@mulkieran mulkieran removed this from In progress (long term) in 2024May May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant