Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PROFILE_FLAGS to profileable targets #891

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add PROFILE_FLAGS to profileable targets #891

wants to merge 4 commits into from

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Nov 13, 2023 •
edited

@mulkieran mulkieran self-assigned this Nov 13, 2023
@mulkieran mulkieran added this to In progress (long term) in 2023November via automation Nov 13, 2023
@mulkieran mulkieran moved this from In progress (long term) to In progress in 2023November Nov 13, 2023
@mulkieran mulkieran force-pushed the issue_project_451 branch 7 times, most recently from 68bcb14 to 24ba7c0 Compare November 14, 2023 02:56
@mulkieran
Copy link
Member Author

Looks like llvm-profdata on ubuntu may be too old to handle format used by rust.

@mulkieran mulkieran moved this from In progress to Pending in 2023November Nov 14, 2023
@mulkieran
.gitignore: exclude files from profiling
2fa28a6 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Add PROFILE_FLAGS to profileable targets
8f21158 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Copy link
Member Author

progress...

@mulkieran
Copy link
Member Author

It works!

@mulkieran mulkieran mentioned this pull request Nov 14, 2023
Open
@mulkieran
Add coverage target to weekly GitHub workflow
818d12a 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
TEMPORARY
c42dbda 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran removed this from Pending in 2023November Dec 4, 2023
@mulkieran mulkieran added this to In progress (long term) in 2023December via automation Dec 4, 2023
@mulkieran mulkieran moved this from In progress (long term) to Pending in 2023December Dec 4, 2023
@mulkieran mulkieran removed this from Pending in 2023December Jan 2, 2024
@mulkieran mulkieran added this to In progress (long term) in 2024January via automation Jan 2, 2024
@mulkieran mulkieran moved this from In progress (long term) to Pending in 2024January Jan 2, 2024
@mulkieran
Copy link
Member Author

mulkieran commented Jan 2, 2024 •
edited

Need to do a pass again through the various recommendations for making coverage useful, i.e., for being able to get a well-synthesized and readable presentation of the actual results.

@mulkieran mulkieran removed this from Pending in 2024January Feb 5, 2024
@mulkieran mulkieran added this to In progress (long term) in 2024February via automation Feb 5, 2024
@mulkieran mulkieran removed this from In progress (long term) in 2024February Mar 5, 2024
@mulkieran mulkieran added this to In progress (long term) in 2024March via automation Mar 5, 2024
@mulkieran mulkieran removed this from In progress (long term) in 2024March Apr 2, 2024
@mulkieran mulkieran added this to changelogs in tracking via automation Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mulkieran mulkieran

Labels
None yet
Projects
tracking
changelogs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mulkieran