Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: u&p FE tests #20289

Merged
merged 2 commits into from
May 9, 2024
Merged

fix: u&p FE tests #20289

merged 2 commits into from
May 9, 2024

Conversation

jhoward1994
Copy link
Contributor

@jhoward1994 jhoward1994 commented May 9, 2024

What does it do?

U&P test changes

Why is it needed?

Fix failures like

https://github.com/strapi/strapi/actions/runs/9015798490/job/24771319080?pr=19898

@jhoward1994 jhoward1994 self-assigned this May 9, 2024
@jhoward1994
Copy link
Contributor Author

@joshuaellis sorry it looks like I didnt get everything in the last PR

Does this seem right to fix failures like strapi/strapi/actions/runs/9015798490/job/24771319080?pr=19898

?

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 1:20pm

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@jhoward1994 jhoward1994 merged commit 8592bde into v5/main May 9, 2024
24 of 29 checks passed
@jhoward1994 jhoward1994 deleted the fix/flaky-fe-tests-2 branch May 9, 2024 13:39
@echoes-hq echoes-hq bot added the echoes/type: maintenance/testing For tests written to support improved automation QA label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/type: maintenance/testing For tests written to support improved automation QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants