Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(history): adjust condition to display missing relations #20267

Merged
merged 1 commit into from
May 6, 2024
Merged

fix(history): adjust condition to display missing relations #20267

merged 1 commit into from
May 6, 2024

Conversation

markkaylor
Copy link
Contributor

@markkaylor markkaylor commented May 6, 2024 •
edited

What does it do?

  • Fix condition from return "No relations" for missing relations

Why is it needed?

  • Missing relations are always represented as no relations

How to test it?

  • Go to a content-type with relations like kitchensink
  • Create some entries to relate to like Tag
  • Attach the relations to kitchensink and create some history versions
  • Now go delete some relations
  • Access previous versions where the relations existed
  • Make sure the correct message is displayed

Relation should display:

  • No relations (including no missing relations) should display "No relatins"
  • Relations + missing relations should display the existing relations + missing relation message
  • Missing relation messages should display the number of missing relations if there are several that are missing.

@markkaylor markkaylor self-assigned this May 6, 2024
@markkaylor markkaylor requested a review from remidej May 6, 2024 12:26
@markkaylor markkaylor added pr: fix This PR is fixing a bug source: core:content-manager Source is core/content-manager package labels May 6, 2024
@vercel Vercel
Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 0:33am

remidej
remidej approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@remidej remidej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works as expected

@markkaylor markkaylor merged commit 17b4116 into v5/main May 6, 2024
27 of 31 checks passed
@markkaylor markkaylor deleted the fix/history-missing-relations branch May 6, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remidej remidej remidej approved these changes

Assignees

@markkaylor markkaylor

Labels
pr: fix This PR is fixing a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markkaylor @remidej