chore: add type to bulk action actions #20256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaellis
added
source: core:content-manager
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
madhurisandbhor
approved these changes
May 3, 2024
| @@ -138,7 +138,6 @@ const BulkActionAction = (action: Action) => { | |||
| break; | |||
| case 'dialog': | |||
| case 'modal': { | |||
| if (action.actionType === 'delete') trackUsage('willBulkDeleteEntries'); | |||
There was a problem hiding this comment.
I changed type to actionType because I needed to do this 😥 and I polluted it. Thanks for the changes!!
There was a problem hiding this comment.
You could add this to the action call of delete before the API request is sent?
madhurisandbhor
merged commit a4e2e61
into
fix/bulk-actions-migration
26 of 31 checks passed
Feranchz
added a commit
that referenced
this pull request
May 9, 2024
* fix: added bulk actions * chore: migrate bulk publish & unpublish to v5 * chore: change findLocales type to accept arrays * chore: fix lint error * chore: migrate bulkDelete to v5 (#20161) * chore: migrate bulkDelete to v5 * chore: change findLocales type to accept strings array * fix: docs prettier styles * chore: remove console.log * enhancement: migrate countManyDraftRelations to v5 * feat: bulk delete with locale selection option * fix: bulk unpublish working without locale support * test: e2e tests updated * fix: documents api change, deleteMany tags updated, test skipped * chore: renaming * test: reverting e2e tests for delete action changes * fix: reverting publish action changes * fix: hide add to release as its not ready to be migrated * fix: error message updated * fix: tests updated for useDocumentAction * fix: updated request params * fix: reverting wrong commit message Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com> * fix: comments updated * chore: renaming * chore: add type to bulk action actions (#20256) * chore: actionType renamed to just type * fix: dont show unpublish button on contentTypes without draft and publish * fix: set a fixed width for FieldActionWrapper on UID input --------- Co-authored-by: Fernando Chavez <fernando.chavez@strapi.io> Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
echoes-hq
bot
added
the
echoes/type: maintenance
Feranchz
added a commit
that referenced
this pull request
May 28, 2024
* fix: added bulk actions * chore: migrate bulk publish & unpublish to v5 * chore: change findLocales type to accept arrays * chore: fix lint error * chore: migrate bulkDelete to v5 (#20161) * chore: migrate bulkDelete to v5 * chore: change findLocales type to accept strings array * fix: docs prettier styles * chore: remove console.log * enhancement: migrate countManyDraftRelations to v5 * feat: bulk delete with locale selection option * fix: bulk unpublish working without locale support * test: e2e tests updated * fix: documents api change, deleteMany tags updated, test skipped * chore: renaming * test: reverting e2e tests for delete action changes * feat: publish action changes * fix: reverting publish action changes * fix: hide add to release as its not ready to be migrated * fix: error message updated * fix: tests updated for useDocumentAction * fix: updated request params * fix: publish action added * fix: publish action changes with documentId * fix: reverting wrong commit message Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com> * fix: comments updated * chore: renaming * chore: add type to bulk action actions (#20256) * chore: actionType renamed to just type * fix: added missing import * test: fixed * fix(content-manager): edit entry button on bulk publish modal * fix: validationError message type is not as expected * fix: ts error * only fetch entries when modal is opened * fix(content-releases): use status to show the published instead of publishedAt --------- Co-authored-by: Fernando Chavez <fernando.chavez@strapi.io> Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
madhurisandbhor
added a commit
that referenced
this pull request
May 29, 2024
* fix: added bulk actions * chore: migrate bulk publish & unpublish to v5 * chore: change findLocales type to accept arrays * chore: fix lint error * chore: migrate bulkDelete to v5 (#20161) * chore: migrate bulkDelete to v5 * chore: change findLocales type to accept strings array * fix: docs prettier styles * chore: remove console.log * enhancement: migrate countManyDraftRelations to v5 * feat: bulk delete with locale selection option * fix: bulk unpublish working without locale support * test: e2e tests updated * fix: documents api change, deleteMany tags updated, test skipped * chore: renaming * test: reverting e2e tests for delete action changes * feat: publish action changes * fix: reverting publish action changes * fix: hide add to release as its not ready to be migrated * fix: error message updated * fix: tests updated for useDocumentAction * fix: updated request params * fix: publish action added * fix: publish action changes with documentId * fix: reverting wrong commit message Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com> * fix: comments updated * chore: renaming * chore: add type to bulk action actions (#20256) * chore: actionType renamed to just type * fix: added missing import * test: fixed * fix(content-manager): edit entry button on bulk publish modal * fix: validationError message type is not as expected * fix: ts error * only fetch entries when modal is opened * fix(content-releases): use status to show the published instead of publishedAt * fix: alignment fix, update selectedEntries to reflect count, reset selectedEntries on locale change * fix: fixed type error --------- Co-authored-by: Fernando Chavez <fernando.chavez@strapi.io> Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
typeto the action signature (no the description interface)Why is it needed?
publishordeleteor swap them out, similar to how document actions work