enhancement: bulk publish migration to v5 #20255
Conversation
* chore: migrate bulkDelete to v5 * chore: change findLocales type to accept strings array * fix: docs prettier styles * chore: remove console.log
…into v5/bulk-publish-unpublish
|
probably someelse (FE) should approve this pr too :) |
| }, | ||
| } = useDocLayout(); | ||
|
|
||
| const shouldDisplayMainField = mainField != null && mainField !== 'id'; |
There was a problem hiding this comment.
Do we really need this variable?
There was a problem hiding this comment.
I prefer to have it because we use twice on the file
| * BoldChunk | ||
| * -----------------------------------------------------------------------------------------------*/ | ||
|
|
||
| const BoldChunk = (chunks: React.ReactNode) => <Typography fontWeight="bold">{chunks}</Typography>; |
There was a problem hiding this comment.
at the end the chunks prop is the children prop, isn't it?
There was a problem hiding this comment.
Yes, but I think formatMessage pass chunks as the children
|
I found two strange behaviours, not sure are related to this PR to be honest. Registrazione.schermo.2024-05-27.alle.11.17.55.mov |
|
And also some validation error messages have no useful meaning, for example |
|
Thanks for the errors @simotae14 ! I discovered a couple of things:
For this last one we can create a ticket because it's a more complicated thing and I think is a v4 error too (I remember something similar in Releases which works the same way) 🤔 |
|
New changes on fetching entries on opening modal LGTM, thanks!!
Would like to know why don't we use publishedAt value? |
@madhurisandbhor because right now we have two versions of the entry (the published one and the in draft one). We want to use the one in draft (to validate it) and in this version publishedAt is null (because is in draft), but we want the "status" (which takes in consideration all the versions of the entry). Actually this change is interesting, probably we want to discuss it more with Yannis Could you add these two issues you found to the blitz docs? 🙏 |
What does it do?
Bulk Publish action migrated to v5 without any v5 design changes.
Related issue(s)/PR(s)