Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CMReleasesContainer test #20250

Merged
merged 2 commits into from
May 3, 2024
Merged

fix: CMReleasesContainer test #20250

merged 2 commits into from
May 3, 2024

Conversation

remidej
Copy link
Contributor

@remidej remidej commented May 2, 2024

What does it do?

Fixes "update not wrapped in act()" error coming from CMReleasesContainer. I found that the async request at the root of the issue seemed to be the useRBAC call in ReleaseActionMenu.

Also fixes an unrelated TS error

Related

same bug as #20233

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 3:17pm

Copy link
Contributor

@markkaylor markkaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice lgtm

@remidej remidej merged commit 86372bc into v5/main May 3, 2024
25 of 31 checks passed
@joshuaellis joshuaellis deleted the fix/releases-act branch May 3, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants