Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(e2e): improve login util stability in develop #20224

Closed
wants to merge 6 commits into from

Conversation

innerdvations
Copy link
Contributor

@innerdvations innerdvations commented Apr 28, 2024

What does it do?

  • Adds a wait for network idle everywhere that we do a click action that causes network activity
  • changes the login utility to clear cookies and navigate to /admin -- this was because rarely there would be an issue where sessions got messed up and a successful login was not being detected and returning the user to the login page
  • updates playwright version
  • fixes some issues on tokens tests
  • use separate page objects for login tests
  • converts some files to typescript
  • add api-token tests that were only on v5 before
  • converts some hardcoded strings to constants

Why is it needed?

A lot of testing enhancements have gone into v5, we need them backported to v4 not only for stability but also to make fewer merge conflicts.

How to test it?

CI e2e tests should pass

Related issue(s)/PR(s)

Once I'm sure this passes consistently on the CI, I'll cherry pick this and do the same thing on develop

DX-1394

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs 🛑 Canceled (Inspect) Apr 29, 2024 2:56pm

@innerdvations innerdvations added source: tooling Source is GitHub tooling/tests/ect pr: fix This PR is fixing a bug labels Apr 28, 2024
@innerdvations innerdvations marked this pull request as draft April 28, 2024 16:04
@innerdvations innerdvations changed the title test(e2e): login util retries when page fails to load tests(e2e): improve login util stability in develop Apr 29, 2024
Copy link
Contributor

github-actions bot commented Apr 29, 2024

Size Change: 0 B

Total Size: 1.31 MB

ℹ️ View Unchanged
Filename Size
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.33 kB
examples/getstarted/build/index.html 610 B
examples/getstarted/build/main.********.js 1.3 MB
examples/getstarted/build/runtime~main.********.js 4.22 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant