Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): update snapshots #20214

Closed
wants to merge 1 commit into from
Closed

Conversation

markkaylor
Copy link
Contributor

What does it do?

  • Updates snapshots

Why is it needed?

  • There was a DS update...I think 🤔
  • It's causing FE tests to break

How to test it?

  • The tests in the CI should pass

@markkaylor markkaylor self-assigned this Apr 26, 2024
@markkaylor markkaylor added pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect labels Apr 26, 2024
Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 11:54am

@markkaylor markkaylor closed this Apr 26, 2024
@markkaylor markkaylor deleted the chore/update-snapshots branch April 26, 2024 11:59
@markkaylor markkaylor restored the chore/update-snapshots branch April 26, 2024 12:11
@markkaylor markkaylor reopened this Apr 26, 2024
@joshuaellis
Copy link
Member

I think this is flakey because of an effect in the header i wonder if we should waitFor the header to have the style height? 🤔

@markkaylor
Copy link
Contributor Author

I think this is flakey because of an effect in the header i wonder if we should waitFor the header to have the style height? 🤔

I had it failing consistently on #20212 but looks like it's passing now after pulling in v5/main again 🤷‍♂️ closing this one.

@markkaylor markkaylor closed this Apr 26, 2024
@joshuaellis joshuaellis deleted the chore/update-snapshots branch May 1, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants