fix(content-manager): delete and unpublish bulk actions migration to v5 #20213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
madhurisandbhor
changed the base branch from
v5/main
to
v5/bulk-publish-unpublish
|
Size Change: +13 B (0%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
joshuaellis
reviewed
Apr 30, 2024
packages/core/content-manager/admin/src/pages/ListView/components/BulkActions/PublishAction.tsx
Outdated
Show resolved
Hide resolved
joshuaellis
requested changes
Apr 30, 2024
packages/core/content-manager/admin/src/pages/ListView/components/BulkActions/Actions.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
323
to
325
| params: { | ||
| locale: isDeleteAllLocale ? '*' : currentLocale, | ||
| }, |
There was a problem hiding this comment.
Look at how we do other actions, lets pass all the plugin params and build them correctly imo.
There was a problem hiding this comment.
but BE expects just locale, can you please give an example?
packages/core/content-manager/admin/src/pages/ListView/components/BulkActions/Actions.tsx
Outdated
Show resolved
Hide resolved
packages/core/content-manager/admin/src/pages/ListView/components/BulkActions/Actions.tsx
Outdated
Show resolved
Hide resolved
packages/core/content-manager/admin/src/pages/ListView/components/BulkActions/Actions.tsx
Outdated
Show resolved
Hide resolved
packages/core/content-manager/admin/src/pages/ListView/components/BulkActions/Actions.tsx
Show resolved
Hide resolved
| const { unpublishMany: bulkUnpublishAction } = useDocumentActions(); | ||
|
|
||
| const handleConfirmBulkUnpublish = async () => { | ||
| const data = await bulkUnpublishAction({ documentIds, model }); |
There was a problem hiding this comment.
We probably need to be sending all the params here otherwise we'll just unpublish the default locale.
There was a problem hiding this comment.
this isn't expecting any params so its default locale only now
madhurisandbhor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Describe the technical changes you did.
Why is it needed?
Describe the issue you are solving.
How to test it?
Provide information about the environment and the path to verify the behaviour.
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request