Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove deprecated verbose option from ts:generate-types #20194

Merged
merged 3 commits into from Apr 29, 2024

Conversation

innerdvations
Copy link
Contributor

@innerdvations innerdvations commented Apr 24, 2024

What does it do?

Removes deprecated verbose option

Why is it needed?

deprecation for v5

How to test it?

it shouldn't work anymore, debug should be the way to change log levels for the command

Related issue(s)/PR(s)

DX-1067

Docs: strapi/documentation#2092

@innerdvations innerdvations added flag: 💥 Breaking change This PR contains breaking changes and should not be merged source: cli Source is cli package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Apr 24, 2024
@innerdvations innerdvations self-assigned this Apr 24, 2024
@echoes-hq echoes-hq bot added the echoes/type: feature Effort to deliver new features, significant feature changes and new functionality label Apr 24, 2024
Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 7:49am

Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui

@Convly
Copy link
Member

Convly commented Apr 24, 2024

You might want to create a similar PR for the documentation though

https://docs.strapi.io/dev-docs/cli#strapi-tsgenerate-types

Copy link
Member

@Bassel17 Bassel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
tested as well

@innerdvations innerdvations merged commit 4300e8f into v5/main Apr 29, 2024
79 of 83 checks passed
@innerdvations innerdvations deleted the chore/remove-deprecated-ts-gen-verbose branch April 29, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/type: feature Effort to deliver new features, significant feature changes and new functionality flag: 💥 Breaking change This PR contains breaking changes and should not be merged pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: cli Source is cli package
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants