feat(main-nav): Main Nav refactoring, add the Home icon #20176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simotae14
added
source: core:admin
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: -27.7 kB (-1%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
joshuaellis
reviewed
Apr 23, 2024
joshuaellis
reviewed
Apr 23, 2024
joshuaellis
dismissed
their stale review
few changes made, best to re-review it :)
madhurisandbhor
approved these changes
Apr 29, 2024
|
I understand your point but for the moment I have just changed some small stuff in the condensed view of the Main nav, I don't think it is a big deal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
In the condensed view of the Left Menu it shows the new Home icon. This new link is responsible to redirect to the home
Why is it needed?
In the refactoring of the Main Nav we want a new home icon to have the task of connecting to the home page, while the logo must only show the image of the logo.
How to test it?
Disclaimer: the new home Link is used only in the condensed view at the moment because I need to implement the components used in the Logo and in the new Home icon before implementing the new MainNav wrapper
Open a Strapi App
in the left Main Nav click on the reduce button, to show the condensed view of the Main Nav
you can now see the new Home icon
if you try to click on the home icon you will be redirected to the home
Please test the themes and all the possible status of the link (on hover, active) and also the popover
You can find all the info and link to the figma file in the Jira ticket
Related issue(s)/PR(s)
CS-764