feat: add exports for convenient extending of the plugin features #20152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chupacabri
changed the title
|
@alexandrebodin, Could you please look at the pr? Thanks. |
|
Hello @chupacabri we will reviews as soon as we can. Please avoid pinging directly people from the team 🙏 |
alexandrebodin
added
source: core:upload
Of course. There is no problem. Thanks for the clarification. |
|
@chupacabri Our CI is complaining about your commit message, (commitlint, can you amend it to feat with conventional commits please) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello strapi contributors,
Thank you for the project!
Please review my idea. It is small and safe change, but it is very important because it opens many ways to customize default behavior of the plugin.
Thanks.
What does it do?
added additional exports to upload plugin
Why is it needed?
exporting of these functions give us an opportunity to reuse they when we want to extend, change or disable part of functionality of the original upload plugin. so we don't have to create a new upload module to change something in behavior of the original plugin, because it is very well, but sometimes we need to have this option.
for example: I would like to change generateBreakpoint algorithm and reuse it after in my own generateResponsiveFormats call which I can override when I extend the plugin or if I would like to extend default behavior of generateResponsiveFormats adding some additional actions.
How to test it?
extend upload plugin with extending and overriding these functions
Related issue(s)/PR(s)
no