Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sharp and pass ignore-engines for yarn v1.x.x #20146

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

markkaylor
Copy link
Contributor

@markkaylor markkaylor commented Apr 18, 2024

What does it do?

  • Bump sharp to 0.33.3
  • Pass the --ignore-engines to the install for yarn v1.x.x users

Experimental: 0.0.0-experimental.1932e6b506cbbdb53c0b8b9ef0f6b5799ebfe7ca

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 9:57am

@markkaylor markkaylor self-assigned this Apr 18, 2024
Copy link
Contributor

Size Change: 0 B

Total Size: 1.31 MB

ℹ️ View Unchanged
Filename Size
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.33 kB
examples/getstarted/build/index.html 609 B
examples/getstarted/build/main.********.js 1.3 MB
examples/getstarted/build/runtime~main.********.js 4.22 kB

compressed-size-action

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. let's do an experimental and test it with multiple yarn setups. Also you can test on the cloud as they have yarn v1 👍

@markkaylor
Copy link
Contributor Author

markkaylor commented Apr 18, 2024

Still have the error when deploying on strapi cloud using the experimental 😞

Screenshot 2024-04-18 at 14 05 14

@alexandrebodin
Copy link
Member

Can you look into it with someone in the cloud team (not super urgent) so we check if the cli runs as expected in the logs etc 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants